electrum

commit e7efc3657b120b13bf2e3d01b7c1095d794cdae1
parent 1e77562bcb262825b915bea5d206f10b467e8b7d
Author: SomberNight <somber.night@protonmail.com>
Date:   Tue, 12 Nov 2019 21:57:07 +0100

fix Qt tx dialog randomly disappearing (due to gc)

Diffstat:
M
electrum/gui/qt/transaction_dialog.py
 | 
3
++-

1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/electrum/gui/qt/transaction_dialog.py b/electrum/gui/qt/transaction_dialog.py
@@ -84,7 +84,6 @@ def show_transaction(tx: Transaction, *, parent: 'ElectrumWindow', invoice=None,
         _logger.exception('unable to deserialize the transaction')
         parent.show_critical(_("Electrum was unable to deserialize the transaction:") + "\n" + str(e))
     else:
-        dialogs.append(d)
         d.show()
 
 
@@ -195,6 +194,8 @@ class BaseTxDialog(QDialog, MessageBoxMixin):
         vbox.addLayout(hbox)
         self.set_buttons_visibility()
 
+        dialogs.append(self)
+
     def set_buttons_visibility(self):
         for b in [self.export_actions_button, self.save_button, self.sign_button, self.broadcast_button, self.partial_tx_actions_button]:
             b.setVisible(self.finalized)