electrum

commit 154b9cab50e7de41fe878359e92f44fd3b07c484
parent 5958fa8b2daf3e75a9fbe392e8f1d0147e7b9d83
Author: SomberNight <somber.night@protonmail.com>
Date:   Wed,  3 Jun 2020 18:18:56 +0200

coinchooser: change "enable_output_value_rounding" default to True

see diff for rationale

Diffstat:
M
electrum/coinchooser.py
 | 
7
++++++-
M
electrum/gui/qt/settings_dialog.py
 | 
2
+-

2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/electrum/coinchooser.py b/electrum/coinchooser.py
@@ -484,7 +484,12 @@ def get_name(config):
 
 def get_coin_chooser(config):
     klass = COIN_CHOOSERS[get_name(config)]
+    # note: we enable enable_output_value_rounding by default as
+    #       - for sacrificing a few satoshis
+    #       + it gives better privacy for the user re change output
+    #       + it also helps the network as a whole as fees will become noisier
+    #         (trying to counter the heuristic that "whole integer sat/byte feerates" are common)
     coinchooser = klass(
-        enable_output_value_rounding=config.get('coin_chooser_output_rounding', False),
+        enable_output_value_rounding=config.get('coin_chooser_output_rounding', True),
     )
     return coinchooser
diff --git a/electrum/gui/qt/settings_dialog.py b/electrum/gui/qt/settings_dialog.py
@@ -316,7 +316,7 @@ you close all your wallet windows. Use this to keep your local watchtower runnin
 
         def on_outrounding(x):
             self.config.set_key('coin_chooser_output_rounding', bool(x))
-        enable_outrounding = bool(self.config.get('coin_chooser_output_rounding', False))
+        enable_outrounding = bool(self.config.get('coin_chooser_output_rounding', True))
         outrounding_cb = QCheckBox(_('Enable output value rounding'))
         outrounding_cb.setToolTip(
             _('Set the value of the change output so that it has similar precision to the other outputs.') + '\n' +