electrum

Electrum Bitcoin wallet
git clone https://git.parazyd.org/electrum
Log | Files | Refs | Submodules

commit d0cfb3ae12dca88ed51f23d68cd2b60a0b46b017
parent 5f817770af7d7ed90df567dde22aa9068ac942f7
Author: ThomasV <thomasv@electrum.org>
Date:   Fri, 30 Aug 2019 09:11:54 +0200

Remove early return in create_sweeptxs_for_our_ctx.
 - This was added because we did not store the complete htlc history.
 - It makes the result dependent on the current channel state
 - That creates a race condition in sweep_info, because the result is cached.
 - As a result, test_breach_with_spent_htlc was randomly failing.

Diffstat:
Melectrum/lnsweep.py | 5-----
1 file changed, 0 insertions(+), 5 deletions(-)

diff --git a/electrum/lnsweep.py b/electrum/lnsweep.py @@ -186,11 +186,6 @@ def create_sweeptxs_for_our_ctx(chan: 'Channel', ctx: Transaction, ctn: int, return # we have to_local, to_remote. # other outputs are htlcs - # if they are spent, we need to generate the script - # so, second-stage htlc sweep should not be returned here - if ctn < chan.get_oldest_unrevoked_ctn(LOCAL): - _logger.info("we breached.") - return {} txs = {} # to_local output_idx = ctx.get_output_idx_from_address(to_local_address)