electrum

commit e20369bf94a2c2c8c22dd9472be3767e90c5774e
parent 93e0c72ce2baff53b8e15b398ffaf6f31b4da35c
Author: Neil Booth <kyuupichan@gmail.com>
Date:   Sun, 24 Jan 2016 20:14:08 +0900

Plugins: remove init_qt hook; clean up

Fixes #1644

Diffstat:
M
gui/qt/__init__.py
 | 
1
-
M
gui/qt/main_window.py
 | 
1
-
M
plugins/exchange_rate/qt.py
 | 
28
++++++++++++++--------------

3 files changed, 14 insertions(+), 16 deletions(-)
diff --git a/gui/qt/__init__.py b/gui/qt/__init__.py
@@ -92,7 +92,6 @@ class ElectrumGui:
         self.build_tray_menu()
         self.tray.show()
         self.app.connect(self.app, QtCore.SIGNAL('new_window'), self.start_new_window)
-        run_hook('init_qt', self)
 
     def build_tray_menu(self):
         # Avoid immediate GC of old menu when window closed via its action
diff --git a/gui/qt/main_window.py b/gui/qt/main_window.py
@@ -2933,7 +2933,6 @@ class ElectrumWindow(QMainWindow, MessageBoxMixin, PrintError):
             p = plugins.toggle(name)
             cb.setChecked(bool(p))
             enable_settings_widget(p, name, i)
-            run_hook('init_qt', self.gui_object)
 
         for i, descr in enumerate(plugins.descriptions.values()):
             name = descr['__name__']
diff --git a/plugins/exchange_rate/qt.py b/plugins/exchange_rate/qt.py
@@ -11,7 +11,11 @@ from functools import partial
 from electrum.plugins import hook
 from exchange_rate import FxPlugin
 
-class Plugin(FxPlugin):
+class Plugin(FxPlugin, QObject):
+
+    def __init__(self, parent, config, name):
+        FxPlugin.__init__(self, parent, config, name)
+        QObject.__init__(self)
 
     def connect_fields(self, window, btc_e, fiat_e, fee_e):
 
@@ -42,15 +46,11 @@ class Plugin(FxPlugin):
         fiat_e.is_last_edited = False
 
     @hook
-    def init_qt(self, gui):
-        self.app = gui.app
-
-    @hook
     def do_clear(self, window):
         window.fiat_send_e.setText('')
 
     def on_close(self):
-        self.app.emit(SIGNAL('close_fx_plugin'))
+        self.emit(SIGNAL('close_fx_plugin'))
 
     def restore_window(self, window):
         window.update_status()
@@ -59,10 +59,10 @@ class Plugin(FxPlugin):
         window.fiat_receive_e.hide()
 
     def on_quotes(self):
-        self.app.emit(SIGNAL('new_fx_quotes'))
+        self.emit(SIGNAL('new_fx_quotes'))
 
     def on_history(self):
-        self.app.emit(SIGNAL('new_fx_history'))
+        self.emit(SIGNAL('new_fx_history'))
 
     def on_fx_history(self, window):
         '''Called when historical fx quotes are updated'''
@@ -86,7 +86,7 @@ class Plugin(FxPlugin):
         ccy = str(self.ccy_combo.currentText())
         if ccy and ccy != self.ccy:
             self.set_currency(ccy)
-            self.app.emit(SIGNAL('new_fx_quotes'))
+            self.emit(SIGNAL('new_fx_quotes'))
             self.hist_checkbox_update()
 
     def hist_checkbox_update(self):
@@ -120,10 +120,10 @@ class Plugin(FxPlugin):
         self.connect_fields(window, window.receive_amount_e, receive_e, None)
         window.history_list.refresh_headers()
         window.update_status()
-        window.connect(window.app, SIGNAL('new_fx_quotes'), lambda: self.on_fx_quotes(window))
-        window.connect(window.app, SIGNAL('new_fx_history'), lambda: self.on_fx_history(window))
-        window.connect(window.app, SIGNAL('close_fx_plugin'), lambda: self.restore_window(window))
-        window.connect(window.app, SIGNAL('refresh_headers'), window.history_list.refresh_headers)
+        window.connect(self, SIGNAL('new_fx_quotes'), lambda: self.on_fx_quotes(window))
+        window.connect(self, SIGNAL('new_fx_history'), lambda: self.on_fx_history(window))
+        window.connect(self, SIGNAL('close_fx_plugin'), lambda: self.restore_window(window))
+        window.connect(self, SIGNAL('refresh_headers'), window.history_list.refresh_headers)
 
     def settings_widget(self, window):
         return EnterButton(_('Settings'), partial(self.settings_dialog, window))
@@ -152,7 +152,7 @@ class Plugin(FxPlugin):
                 self.get_historical_rates()
             else:
                 self.config.set_key('history_rates', 'unchecked')
-            self.app.emit(SIGNAL('refresh_headers'))
+            self.emit(SIGNAL('refresh_headers'))
 
         def ok_clicked():
             self.timeout = 0